[PATCH] D95450: [clangd] Respect ReferencesParams.context.includeDeclarations

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 1 08:07:25 PST 2021


sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/XRefs.h:86
+  enum ReferenceAttributes : unsigned {
+    Plain = 0,
+    Declaration = 1 << 0,
----------------
kbobyrev wrote:
> nit: `Plain` means neither `Declaration` nor `Definition`, right? Maybe `None` then?
Haha, this is actually unused.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95450/new/

https://reviews.llvm.org/D95450



More information about the cfe-commits mailing list