[PATCH] D95660: [NFC] Disallow unused prefixes under clang/test/Driver

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 29 18:17:27 PST 2021


MaskRay added inline comments.


================
Comment at: clang/test/Driver/rocm-device-libs.cl:82
 // RUN:   %s \
-// RUN: 2>&1 | FileCheck  --check-prefixes=COMMON,COMMON-UNSAFE,GFX803,WAVE64 %s
+// RUN: 2>&1 | FileCheck  --check-prefixes=COMMON,GFX803,WAVE64 %s
 
----------------
mtrofin wrote:
> MaskRay wrote:
> > Since you changing the lines, consider indenting `2>&1`
> > 
> > The most common style is to place `2>&1 | \` on the previous line.
> done
All the continuation lines should be indented, i.e. `FileCheck` needs to be indented...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95660/new/

https://reviews.llvm.org/D95660



More information about the cfe-commits mailing list