[PATCH] D87928: Provide -fsource-dir flag in Clang

[Petr Hosek via Phabricator via cfe-commits]

phosek added a comment.

I'm picking up this change again after D83154 <https://reviews.llvm.org/D83154> landed. I did some tracing and it looks like `FileManager` already returns a relative path when relative path was passed to the compiler as you'd expect so I don't think we need to change anything there. It's CoverageMappingModuleGen::normalizeFilename <https://github.com/llvm/llvm-project/blob/ebe74d9592d097501f376c2086e58d35aa318896/clang/lib/CodeGen/CoverageMappingGen.cpp#L1596> that makes the path absolute so perhaps if we restrict this change only to coverage mapping, perhaps we should just introduce a flag to disable that behavior, for example `-f[no]-normalize-coverage-mapping`, or to normalize paths as relative against a given directory, for example `-fcoverage-mapping-dir=[DIR]`. What do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87928/new/

https://reviews.llvm.org/D87928