[clang-tools-extra] 632545e - [clang-tidy] Fix linking tests to LLVMTestingSupport

Michał Górny via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 29 12:54:23 PST 2021


Author: Michał Górny
Date: 2021-01-29T21:54:09+01:00
New Revision: 632545e8ce846ccaeca8df15a3dc5e36d01a1275

URL: https://github.com/llvm/llvm-project/commit/632545e8ce846ccaeca8df15a3dc5e36d01a1275
DIFF: https://github.com/llvm/llvm-project/commit/632545e8ce846ccaeca8df15a3dc5e36d01a1275.diff

LOG: [clang-tidy] Fix linking tests to LLVMTestingSupport

LLVMTestingSupport is not part of libLLVM, and therefore can not
be linked to via LLVM_LINK_COMPONENTS.  Instead, it needs to be
specified explicitly to ensure that it is linked explicitly
even if LLVM_LINK_LLVM_DYLIB is used.  This is consistent with handling
in clangd.

Fixes PR#48931

Differential Revision: https://reviews.llvm.org/D95653

Added: 
    

Modified: 
    clang-tools-extra/unittests/clang-tidy/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/unittests/clang-tidy/CMakeLists.txt b/clang-tools-extra/unittests/clang-tidy/CMakeLists.txt
index be35b71d15cf..05d330dd8033 100644
--- a/clang-tools-extra/unittests/clang-tidy/CMakeLists.txt
+++ b/clang-tools-extra/unittests/clang-tidy/CMakeLists.txt
@@ -1,7 +1,6 @@
 set(LLVM_LINK_COMPONENTS
   FrontendOpenMP
   Support
-  TestingSupport
   )
 
 get_filename_component(CLANG_LINT_SOURCE_DIR
@@ -46,4 +45,5 @@ target_link_libraries(ClangTidyTests
   clangTidyObjCModule
   clangTidyReadabilityModule
   clangTidyUtils
+  LLVMTestingSupport
   )


        


More information about the cfe-commits mailing list