[PATCH] D95635: [CMake] Actually require python 3.6 or greater

[Jonas Devlieghere via Phabricator via cfe-commits]

JDevlieghere reopened this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

In D95635#2529027 <https://reviews.llvm.org/D95635#2529027>, @ctetreau wrote:

> In D95635#2528851 <https://reviews.llvm.org/D95635#2528851>, @JDevlieghere wrote:
>
>>> However, the project claims to require 3.6 or greater, and 3.6 features are being used.
>>
>> Can you link to where it says that? I'm not opposed to making 3.6 the minimally required version, but at least for LLDB we don't have that requirement and we have documentation mentioning Python 3.5.
>
>
>
> In D95635#2528883 <https://reviews.llvm.org/D95635#2528883>, @yln wrote:
>
>> In D95635#2528851 <https://reviews.llvm.org/D95635#2528851>, @JDevlieghere wrote:
>>
>>>> However, the project claims to require 3.6 or greater, and 3.6 features are being used.
>>>
>>> Can you link to where it says that? I'm not opposed to making 3.6 the minimally required version, but at least for LLDB we don't have that requirement and we have documentation mentioning Python 3.5.
>>
>> For LLVM: https://llvm.org/docs/GettingStarted.html#software
>
> This is where I saw it. I got bit by @yln's cleanup patch. I can reduce the minimum version for LLDB if that's the officially required version, but llvm at the very least advertises 3.6

That page says "known to work" which is not exactly the same a minimally supported. In a unified build there's also no way to say LLVM requires Python 3.6 but LLDB only requires Python 3.5 because we use the same variables and we need to keep that in sync as to not run the test suite under one Python version while linking against another.

I see the patch got reverted because not all the bots have Python 3.6. What's the lowest Python version that they're running? Is there a reason 3.6 should be the minimally supported version?

Again, I'm not opposed to this, but it warrants a bit more discussion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95635/new/

https://reviews.llvm.org/D95635