[PATCH] D95460: [flang][driver] Add forced form flags and -ffixed-line-length

[Tim Keith via Phabricator via cfe-commits]

tskeith added inline comments.


================
Comment at: clang/include/clang/Driver/Options.td:4133
 def fconvert_EQ : Joined<["-"], "fconvert=">, Group<gfortran_Group>;
-def ffixed_line_length_VALUE : Joined<["-"], "ffixed-line-length-">, Group<gfortran_Group>;
+def ffixed_line_length_VALUE : Joined<["-"], "ffixed-line-length-">, Flags<[FlangOption, FC1Option]>,
+  Group<gfortran_Group>, HelpText<"Use <value> as character line width in fixed mode">,
----------------
Why isn't this `-ffixed-line-length=<value>` (i.e. with an equals sign, not a hyphen)? Isn't that how clang does options with values? It's fine to support the gfortran form as an alternative but I think the primary goal should be good consistent style for options.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95460/new/

https://reviews.llvm.org/D95460