[PATCH] D95665: [Builtins][FIX] Allow targets to opt-out of `long double` builtins

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 29 08:21:36 PST 2021


yaxunl added a comment.

I tried this patch with our CI and it breaks HIP and OpenMP. I suspect it may also break CUDA. It seems in device compilation, when a host function calls a builtin with long double argument, the builtin is not found. My guess is that the target for checking builtin needs to be caller dependent. E.g. in device compilation, when checking builtin called by a host function, aux-target and aux-cpu should be used. Then this raises another question: what to use for host device function? It seems for this to work, the dianostic about missing builtin needs to be also deferred diagnostics.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95665/new/

https://reviews.llvm.org/D95665



More information about the cfe-commits mailing list