[PATCH] D95653: [clang-tidy] Fix linking tests to LLVMTestingSupport
Nathan James via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 29 06:00:38 PST 2021
njames93 added a comment.
In D95653#2530163 <https://reviews.llvm.org/D95653#2530163>, @mgorny wrote:
> In D95653#2529776 <https://reviews.llvm.org/D95653#2529776>, @njames93 wrote:
>
>> I think I introduced this failure due to my abysmal
In D95653#2530163 <https://reviews.llvm.org/D95653#2530163>, @mgorny wrote:
> In D95653#2529776 <https://reviews.llvm.org/D95653#2529776>, @njames93 wrote:
>
>> I think I introduced this failure due to my abysmal knowledge of CMake and LLVM's library structure, So I'm definitely not qualified to say if this is a good fix, but seeing as it fixes the linker error I'll give it a tentative LG.
>
> I'm a bit confused now. Are you telling that I should push it or wait for another review?
I was just saying wait for another reviewer to approve it. But it's all good now
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95653/new/
https://reviews.llvm.org/D95653
More information about the cfe-commits
mailing list