[PATCH] D95450: [clangd] Respect ReferencesParams.context.includeDeclarations

[Kirill Bobyrev via Phabricator via cfe-commits]

kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.

Thanks, LGTM with a couple of nits.



================
Comment at: clang-tools-extra/clangd/XRefs.h:23
 #include "clang/AST/Type.h"
+#include "clang/Basic/BitmaskEnum.h"
 #include "clang/Format/Format.h"
----------------
nit: are these two needed? I can't see any usages of symbols defined there.


================
Comment at: clang-tools-extra/clangd/XRefs.h:86
+  enum ReferenceAttributes : unsigned {
+    Plain = 0,
+    Declaration = 1 << 0,
----------------
nit: `Plain` means neither `Declaration` nor `Definition`, right? Maybe `None` then?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95450/new/

https://reviews.llvm.org/D95450