[PATCH] D95166: Disable rosegment for old Android versions.

dmajor via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 28 16:15:12 PST 2021


dmajor added a comment.

It does feel kind of awkward to me that _this_ is the patch that ends up breaking the builds, versus something at the cmake level that says "you are explicitly unsupported".

Also it's unfortunate that this landed just hours before 12.0.0 branched. Had it landed slightly later, release users could have six months to plan for the change. You say that the next NDK compiler is based on ToT, in that case would it make sense to revert this on the 12.x branch, and add a warning to the 12.0.0 release notes that lld will be assumed in 13?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95166/new/

https://reviews.llvm.org/D95166



More information about the cfe-commits mailing list