[PATCH] D95369: [clang][cli] Generate and round-trip analyzer options
Duncan P. N. Exon Smith via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 28 12:14:57 PST 2021
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM.
================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:822
+
static bool ParseAnalyzerArgs(AnalyzerOptions &Opts, ArgList &Args,
DiagnosticsEngine &Diags) {
----------------
Can you rename this `ParseAnalyzerArgsImpl` for better readability?
================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1002
+
+ return RoundTrip(Parse, Generate, Swap, Res, Args, Diags, "AnalyzerOptions");
+}
----------------
I wonder if these lambdas could/should just be defined inline in the call to `RoundTrip`, but up to you to decide.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95369/new/
https://reviews.llvm.org/D95369
More information about the cfe-commits
mailing list