[PATCH] D95514: [clang][cli] Teach CompilerInvocation to allocate strings on its own

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added a comment.

In D95514#2528407 <https://reviews.llvm.org/D95514#2528407>, @Bigcheese wrote:

> In D95514#2528324 <https://reviews.llvm.org/D95514#2528324>, @jansvoboda11 wrote:
>
>> I've looked through all option classes in `CompilerInvocation`, and `AnalyzerOptions::Config` seems to be the only member that stores non-owning references to command line arguments.
>> I think the best path forward is to change `AnalyzerOptions` to take ownership and avoid dealing with complicated lifetimes. We can look into removing allocations later, as an optional optimization.
>> What do you think?
>
> I think that makes sense given the rest of `CompilerInvocation` is owning.

+1, let's just simplify this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95514/new/

https://reviews.llvm.org/D95514