[PATCH] D95629: [clang][analyzer] Own string keys in AnalyzerOptions::ConfigTable

[Jan Svoboda via Phabricator via cfe-commits]

jansvoboda11 created this revision.
jansvoboda11 added reviewers: Bigcheese, dexonsmith.
Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

This patch replaces `StringMap<...>` with `std::map<std::string, ...>` in `AnalyzerOptions::ConfigTable`. It seems to be the only non-owning reference to command line arguments in the whole `CompilerInvocation`, which would introduce a lot of complexity with round-tripping arguments (D94472 <https://reviews.llvm.org/D94472>).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D95629

Files:
  clang/include/clang/StaticAnalyzer/Core/AnalyzerOptions.h
  clang/lib/Frontend/CompilerInvocation.cpp
  clang/lib/StaticAnalyzer/Checkers/DebugCheckers.cpp
  clang/lib/StaticAnalyzer/Core/AnalyzerOptions.cpp
  clang/lib/StaticAnalyzer/Frontend/CheckerRegistry.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95629.319895.patch
Type: text/x-patch
Size: 5073 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210128/03e567d6/attachment.bin>