[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

[Abhina Sree via Phabricator via cfe-commits]

abhina.sreeskantharajan added inline comments.


================
Comment at: llvm/utils/lit/lit/llvm/config.py:349-351
+        triple = ""
+        if hasattr(self.config, 'host_triple'):
+            triple = self.config.host_triple
----------------
jhenderson wrote:
> abhina.sreeskantharajan wrote:
> > jhenderson wrote:
> > > I'm concerned that someone might start using these substitutions in a project for the first time, and get confused why they don't work on non-windows platforms. Maybe the solution is simply to require LLVM_HOST_TRIPLE to be set in all projects, i.e. go back to what you were doing before, and letting python fail if it isn't set.
> > > 
> > > Happy to hear other ideas too.
> > I think using sys.platform or platform.system() could be a better alternative. What do you think?
> Makes sense to me. Slight issue: cygwin on Windows uses `cygwin`. What error message does it produce though?
I tested this out. On a cygwin terminal on Windows it emits the same error message as Linux so it should take the else path.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95246/new/

https://reviews.llvm.org/D95246