[PATCH] D95576: [clangd] Remove support for pre-standard semanticHighlighting notification

Thu Jan 28 00:24:21 PST 2021

sammccall marked an inline comment as done.
sammccall added a comment.

In D95576#2527407 <https://reviews.llvm.org/D95576#2527407>, @kadircet wrote:

> oh also in addition to `This should not land until the new protocol has feature parity, see D77702.`, it might be better to hold on to it a little bit longer, since it is touching lots of pieces and might make cherry-picking some fixes that touch the same files harder to the release branch.

Yeah I don't want to land this for a couple of weeks in any case.
On the other hand, the release branch has sometimes been long-lived (months) and I don't think we should try to avoid invasive changes until the release has landed necessarily, it could eat a good fraction of the release cycle.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95576/new/

https://reviews.llvm.org/D95576