[PATCH] D95538: [clang][Format] Evaluate FallbackStyle only if needed

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 27 23:59:20 PST 2021


kadircet added a comment.

In D95538#2527335 <https://reviews.llvm.org/D95538#2527335>, @curdeius wrote:

> Why is fixing (or removing) the fallback style in the .clang-format file not enough??

sure that would be one way to go, and that's what the user did already.
It feels confusing to me that `getStyle()` fails when provided with a malformed `FallbackStyle`. Even if it is not going to be returned. Are there any workflows that benefit from this behaviour?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95538/new/

https://reviews.llvm.org/D95538



More information about the cfe-commits mailing list