[clang-tools-extra] 29472bb - [clangd] Log warning when using legacy (theia) semantic highlighting.
Sam McCall via cfe-commits
cfe-commits at lists.llvm.org
Wed Jan 27 16:29:55 PST 2021
Author: Sam McCall
Date: 2021-01-28T01:29:28+01:00
New Revision: 29472bb76915c4929aecc938300f6df31f63ac29
URL: https://github.com/llvm/llvm-project/commit/29472bb76915c4929aecc938300f6df31f63ac29
DIFF: https://github.com/llvm/llvm-project/commit/29472bb76915c4929aecc938300f6df31f63ac29.diff
LOG: [clangd] Log warning when using legacy (theia) semantic highlighting.
The legacy protocol will be removed on trunk after the 12 branch cut,
and gone in clangd 13.
Differential Revision: https://reviews.llvm.org/D95031
Added:
Modified:
clang-tools-extra/clangd/ClangdLSPServer.cpp
Removed:
################################################################################
diff --git a/clang-tools-extra/clangd/ClangdLSPServer.cpp b/clang-tools-extra/clangd/ClangdLSPServer.cpp
index dc89ebd59fe2..35aed2166f03 100644
--- a/clang-tools-extra/clangd/ClangdLSPServer.cpp
+++ b/clang-tools-extra/clangd/ClangdLSPServer.cpp
@@ -510,6 +510,11 @@ void ClangdLSPServer::onInitialize(const InitializeParams &Params,
"semanticTokens request, choosing the latter (no notifications).");
Opts.TheiaSemanticHighlighting = false;
}
+ if (Opts.TheiaSemanticHighlighting) {
+ log("Using legacy semanticHighlights notification, which will be removed "
+ "in clangd 13. Clients should use the standard semanticTokens "
+ "request instead.");
+ }
if (Params.rootUri && *Params.rootUri)
Opts.WorkspaceRoot = std::string(Params.rootUri->file());
More information about the cfe-commits
mailing list