[PATCH] D95576: [clangd] Remove support for pre-standard semanticHighlighting notification

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 27 16:17:17 PST 2021


sammccall created this revision.
sammccall added reviewers: nridge, kadircet.
Herald added subscribers: usaxena95, jfb, arphaman, mgrang, javed.absar.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang.

This is obsoleted by the standard semanticTokens request family.
As well as the protocol details, this allows us to remove a bunch of plumbing
around pushing highlights to clients.

This should not land until the new protocol has feature parity, see D77702 <https://reviews.llvm.org/D77702>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D95576

Files:
  clang-tools-extra/clangd/ClangdLSPServer.cpp
  clang-tools-extra/clangd/ClangdLSPServer.h
  clang-tools-extra/clangd/ClangdServer.cpp
  clang-tools-extra/clangd/ClangdServer.h
  clang-tools-extra/clangd/Protocol.cpp
  clang-tools-extra/clangd/Protocol.h
  clang-tools-extra/clangd/SemanticHighlighting.cpp
  clang-tools-extra/clangd/SemanticHighlighting.h
  clang-tools-extra/clangd/TUScheduler.h
  clang-tools-extra/clangd/refactor/tweaks/AnnotateHighlightings.cpp
  clang-tools-extra/clangd/test/semantic-highlighting.test
  clang-tools-extra/clangd/test/semantic-tokens.test
  clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp
  clang-tools-extra/clangd/unittests/tweaks/AnnotateHighlightingsTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95576.319709.patch
Type: text/x-patch
Size: 42261 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210128/b4ffa450/attachment-0001.bin>


More information about the cfe-commits mailing list