[PATCH] D95487: Itanium Mangling: Fix handling of <expr-primary> in <template-arg>.

James Y Knight via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 27 13:49:38 PST 2021


jyknight added inline comments.


================
Comment at: clang/lib/AST/ItaniumMangle.cpp:5145
+  ASTContext &Ctx = Context.getASTContext();
+  if (Ctx.getLangOpts().getClangABICompat() > LangOptions::ClangABI::Ver11) {
+    mangleExpression(E, UnknownArity, /*AsTemplateArg=*/true);
----------------
rsmith wrote:
> Given that we've now branched for the Clang 12 release, please make sure you either backport this to the Clang 12 release branch or bump this to `> Ver12`.
I think this series of patches should be pushed to clang 12, and will thus keep the version as-is, and ensure it makes it into the newly-created branch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95487/new/

https://reviews.llvm.org/D95487



More information about the cfe-commits mailing list