[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added a comment.

In D91913#2525993 <https://reviews.llvm.org/D91913#2525993>, @hvdijk wrote:

> @rnk Taking it upon yourself to revert this without approval and without communication on all branches, especially given the earlier suggestion by @rsmith to only revert this on the LLVM 12 branch, is an abuse of your commit privileges as far as I am concerned. This is not a Google project. Google does not get to unilaterally dictate its direction. I do not intend to get into a revert-the-revert war and will not revert your revert myself. I do expect you to do so.

I think @rnk's observation that `__VA_OPT__` isn't actually available in any compilation mode other than C++20 (which I hadn't previously realized) is important here: we'd left longstanding users of this functionality with no path forward, and that is, I think, sufficient motivation for a revert. I'm working on a patch to make `__VA_OPT__` available across all language modes. Once that's landed, the next step should be adding the warning to trunk and the Clang 12 branch, and then we can decide how long we want the warning in trunk before we make the conformance change -- while we're not beholden to the needs of any particular Clang user, Clang doesn't exist in a vacuum, and giving our live-at-head users a little time to adapt to this change seems reasonable, especially given that there doesn't seem to be any particular urgency in this fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91913/new/

https://reviews.llvm.org/D91913