[PATCH] D95439: [clangd] Add include-fixer fixit for field_incomplete_or_sizeless diagnostic.

Wed Jan 27 06:10:36 PST 2021

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

LGTM!

================
Comment at: clang-tools-extra/clangd/IncludeFixer.cpp:81
   case diag::err_func_def_incomplete_result:
+  case diag::err_field_incomplete_or_sizeless:
     // Incomplete type diagnostics should have a QualType argument for the
----------------
hokein wrote:
> kadircet wrote:
> > what about the `sizless` case ? we'll attach a fixit, but it is not going to fix the issue :(
> The [sizeless](https://reviews.llvm.org/D62962) type is a clang extension, I think our indexer doesn't index this kind of symbols, so we will not attach a fixit for them. 
> 
> And I think sizeless case is rare in practice, I would not too worry about it.
ah ok, i thought this was something more common like a recorddecl without any members and with a specific attribute. thanks for the link!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95439/new/

https://reviews.llvm.org/D95439