[PATCH] D95519: [clang-tidy] bugprone-assert-side-effect: Warn on NSAssert by default.

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM!

> I'm also interested in making an even more agressive step in this direction and adding an option to accept any macro that ends with "...assert" suffix, case-insensitively. This would probably go under an off-by-default flag. Would this be acceptable?

I think that makes sense to me. We should probably look at popular OS SDKs and CRTs to see what creative ways they spell assertion macros to make sure those are covered as well, like https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/assert-asserte-assert-expr-macros?view=msvc-160 and https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/wdm/nf-wdm-assertmsg


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95519/new/

https://reviews.llvm.org/D95519