[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM

Pengfei Wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jan 26 18:25:11 PST 2021


pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: clang/lib/CodeGen/CGStmt.cpp:2491
+        std::string::size_type position1 =
+            Constraints.find("={" + Clobber.str() + "}");
+        if (position1 != std::string::npos) {
----------------
I'm not sure if there's real case that there's `"={edx}"` for MS inline asm, but there's no problem we handle it here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94466/new/

https://reviews.llvm.org/D94466



More information about the cfe-commits mailing list