[PATCH] D85474: Add -fbinutils-version= to gate ELF features on the specified binutils version

Tue Jan 26 11:56:51 PST 2021

MaskRay added a comment.

In D85474#2523439 <https://reviews.llvm.org/D85474#2523439>, @rsmith wrote:

> Clang side looks good to me.
>
> On the LLVM side, is it intended that invalid `-binutils-version` values are silently accepted?

Yes. In `llvm/tools/llc/llc.cpp`, there is no validity check. For these non-user-facing utilities (opt/llc/llvm-mc/...), validity check for options tends to be scarce.

I can add some tests to `llvm/test/tools/llc` (which hardly has any test currently).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85474/new/

https://reviews.llvm.org/D85474