[PATCH] D94466: [X86] merge "={eax}" and "~{eax}" into "=&eax" for MSInlineASM
Freddy, Ye via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jan 26 03:29:22 PST 2021
FreddyYe added inline comments.
================
Comment at: clang/lib/CodeGen/CGStmt.cpp:2490
+ continue;
+ std::string::size_type position1 = Constraints.find("={eax}");
+ if (position1 != std::string::npos) {
----------------
pengfei wrote:
> If `Clobber` is `edx` only, we shouldn't change `"={eax}"` to `"=&{eax}"`.
Yes! I'll update and add a test. THX for review!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94466/new/
https://reviews.llvm.org/D94466
More information about the cfe-commits
mailing list