[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

Harald van Dijk via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 25 13:51:50 PST 2021


hvdijk added a comment.

In D91913#2521031 <https://reviews.llvm.org/D91913#2521031>, @thakis wrote:

> We (and every other project out there) needs some incremental rollout plan for this.

Cut the hyperbole please, this change does not affect "every other project out there". This change makes clang match GCC's 15+-year behaviour that other projects out there will have come to expect. I find it baffling that Chrome/Chromium developers would rely on a bug, knowing full well it's a bug judging from their own comments, and then not take responsibility for the breakage when that bug is fixed. However, I'll defer to @rsmith on whether this is sufficient reason for reverting, I do not feel qualified to make that judgement.

The MSVC compatibility, however, is something I hadn't foreseen and had just submitted a fix for, D95392 <https://reviews.llvm.org/D95392>. If this change is to be reverted, I'll withdraw that followup fix for now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91913/new/

https://reviews.llvm.org/D91913



More information about the cfe-commits mailing list