[PATCH] D94875: [clangd] ignore parallelism level for quick tasks

Quentin Chateau via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 25 12:02:54 PST 2021


qchateau added a comment.

I applied your suggestion as I agree with both. I chose to use `Opts.AsyncThreadsCount` instead of a hard-coded constant. This way the "formatting speed" will grow as the user allow more parallelism, which IMO makes sense.

I agree the implementation had drawbacks but this is the ever-ending problem of non-preemptable tasks. You can land this if this looks good to you.

Commit email: quentin.chateau at gmail.com


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94875/new/

https://reviews.llvm.org/D94875



More information about the cfe-commits mailing list