[PATCH] D91913: Suppress non-conforming GNU paste extension in all standard-conforming modes

Harald van Dijk via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 25 10:32:50 PST 2021


hvdijk added a comment.

In D91913#2520432 <https://reviews.llvm.org/D91913#2520432>, @zequanwu wrote:

> In D91913#2520414 <https://reviews.llvm.org/D91913#2520414>, @hvdijk wrote:
>
>> In D91913#2520399 <https://reviews.llvm.org/D91913#2520399>, @zequanwu wrote:
>>
>>> This change also breaks many chrome ToT bots(not just windows bot), example build: https://ci.chromium.org/ui/p/chrome/builders/ci/ToTLinuxOfficial/10524/steps?succeeded=true&debug=false
>>
>> That requires an account to see.
>
> This should be accessible without an account: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8857139118288337920/+/steps/compile/0/stdout

Indeed. However, here, this seems to be a user problem. Chrome `-std=c++*` when building with clang, but `-std=gnu++*` when building with GCC for exactly this reason, see build/config/compiler/BUILD.gn. Chrome should use `-std=gnu++*` with clang too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91913/new/

https://reviews.llvm.org/D91913



More information about the cfe-commits mailing list