[PATCH] D95340: [clang][cli] NFC: Simplify BoolOption API

Mon Jan 25 03:34:33 PST 2021

jansvoboda11 created this revision.
jansvoboda11 added reviewers: dexonsmith, Bigcheese.
Herald added subscribers: dang, jfb.
jansvoboda11 requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: cfe-commits, sstefan1.
Herald added a project: clang.

The `Bool{,F,G}Option` TableGen classes were designed after `Opt{In,Out}FFlag`, which puts marshalling info on only one of the boolean options. To know which option is supposed to be visible on -cc1 command-line, we used `ChangedBy` and `ResetBy` classes to describe the flags. However, we now put marshalling info on both records (see D93008 <https://reviews.llvm.org/D93008> for details), which means we don't really need `ChangedBy` and `ResetBy` anymore.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D95340

Files:
  clang/include/clang/Driver/Options.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95340.318940.patch
Type: text/x-patch
Size: 83784 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210125/3b8b9d0e/attachment-0001.bin>