[PATCH] D95307: [StaticAnalyzer] Add checking for degenerate base class in MemRegion

Valeriy Savchenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jan 25 03:19:23 PST 2021


vsavchenko added a comment.

In D95307#2519300 <https://reviews.llvm.org/D95307#2519300>, @RedDocMD wrote:

> In D95307#2519283 <https://reviews.llvm.org/D95307#2519283>, @vsavchenko wrote:
>
>> In D95307#2518592 <https://reviews.llvm.org/D95307#2518592>, @NoQ wrote:
>>
>>> This patch shoots the messenger but someone still needs to conduct a proper investigation. The assertion is losing a lot more of its bug-finding power than necessary to uncover the current cornercase; i really hope to preserve it instead.
>>
>> You mean the failing assertion from the tests?
>
> Few hours before there was a message saying that there was some buggy commit to the build-bot. Are you referring to the build failure above?

Yep. TBH I didn't take a good look at the failure, but judging even by the name of the failing test, it looks directly related to the subject of this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95307/new/

https://reviews.llvm.org/D95307



More information about the cfe-commits mailing list