[PATCH] D95246: [SystemZ][z/OS] Fix No such file or directory expression error matching in lit tests - continued

Mon Jan 25 00:29:36 PST 2021

jhenderson added a subscriber: grimar.
jhenderson added a comment.

Sorry, could you revert this please. I don't think this is a good fix, as you've reduced coverage within the test, and some changes are completly redundant/add extra noise. I've commented inline with examples. Skimming D94239 <https://reviews.llvm.org/D94239> suggests that has the same issue.

Could you also please explain the messages your system is actually producing so we can provide a better solution than this fix.

I'm also concerned that you are doing this to fix this test for a system, yet there are no build bots that report this error. A future contributor is likely to break them in the same way/add new tests with the same issue. If your system is a system that is supposed to be supported by LLVM, there needs to be a build bot. If it isn't supported, you should bring this up on llvm-dev (if you haven't already) to get buy-in for support.

================
Comment at: clang/test/Driver/clang-offload-bundler.c:75
 // RUN: not clang-offload-bundler -type=i -targets=host-%itanium_abi_triple,openmp-powerpc64le-ibm-linux-gnu,openmp-x86_64-pc-linux-gnu -outputs=%t.i,%t.tgt1,%t.tgt2 -inputs=%t.bundle.i.notexist -unbundle 2>&1 | FileCheck %s -DFILE=%t.bundle.i.notexist --check-prefix CK-ERR5
-// CK-ERR5: error: '[[FILE]]': {{N|n}}o such file or directory
+// CK-ERR5: error: '[[FILE]]': {{.*}}{{N|n}}o such file or directory

----------------
Here and everywhere you've added the `{{.*}}`, the test will no longer pick up changes in the message that occur between the end of the literal match and the start of the "no such file..." part. For example, this will no longer fail if the message reported became "error: 'afile': fsdufbsdufbno such file or directory"

Even were adding `.*` desirable, it should be part of the following regex, i.e. `{{.*N|n}}` to reduce the noise of the `{{` and `}}`.

================
Comment at: llvm/test/Object/archive-extract-dir.test:11

-CHECK: foo: {{[Ii]}}s a directory
+CHECK: foo: {{.*}}{{[Ii]}}s a directory{{.*}}
----------------
`{{.*}}` at the end of a FileCheck line has literally no benefit - it is implicit unless `--match-full-lines` is specified to `FileCheck`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95246/new/

https://reviews.llvm.org/D95246