[PATCH] D92290: [clangd] Factor out the heuristic resolver code into its own class
Nathan Ridge via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jan 25 00:02:56 PST 2021
nridge added a comment.
Thanks for the thoughtful comments about the API surface and such! I think I've addressed or responded to most of them.
There are a few outstanding comments about how the HeuristicResolver object is stored and passed around (const, pointer, etc.), which I'll come back to once we come to a resolution on the nullability question.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92290/new/
https://reviews.llvm.org/D92290
More information about the cfe-commits
mailing list