[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

Sun Jan 24 11:52:16 PST 2021

HazardyKnusperkeks accepted this revision.
HazardyKnusperkeks added a comment.

I did not re-accept this, because of the script change. I'm okay with it, but I never looked really at the script. I think it should be changed afterwards to error or warn again, but not on this enum. Maybe one could annotate enums which don't have to be fully documented?

I'm okay with making that change in another revision which does not land in LLVM 12.

In D93986#2518309 <https://reviews.llvm.org/D93986#2518309>, @tinloaf wrote:

> In D93986#2518259 <https://reviews.llvm.org/D93986#2518259>, @curdeius wrote:
>
>> Do you have commit access?
>
> Since this is my first contribution to LLVM ever, probably not.

That's what I thought, but I got it.
https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93986/new/

https://reviews.llvm.org/D93986