[PATCH] D95231: [clangd] Selection handles CXXBaseSpecifier

Nathan James via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jan 24 06:49:37 PST 2021


njames93 added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:272-283
+          R"cpp(
+            struct Foo {};
+            struct Bar : [[private Fo^o]] {};
+          )cpp",
+          "CXXBaseSpecifier",
+      },
+      {
----------------
Is this good behaviour, or should Foo selection resolve as a RecordTypeLoc, That is the behaviour previously observed for these 2 cases. And instead have CXXBaseSpecifier as its parent selection?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95231/new/

https://reviews.llvm.org/D95231



More information about the cfe-commits mailing list