[PATCH] D95249: [NFC] Disallow unused prefixes in clang/test/Analysis
    Artem Dergachev via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Fri Jan 22 19:22:27 PST 2021
    
    
  
NoQ added a comment.
I added those for consistency but i think your effort is worth it so let's ditch them.
================
Comment at: clang/test/Analysis/exploded-graph-rewriter/trimmers.dot:4
 // RUN: %exploded_graph_rewriter -s %s \
-// RUN:     | FileCheck %s -check-prefixes=ONE,TWO,NOTHREE,FOUR
 // RUN: %exploded_graph_rewriter --to=0x2 %s \
----------------
Uh-oh, these look like typos as there are lines for `NOTTHREE` and `NOTFOUR`. Looks like your effort has paid off and found a real bug in tests! The tests seem to be passing just fine after i change to `NOTTHREE` and `NOTFOUR` respectively.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95249/new/
https://reviews.llvm.org/D95249
    
    
More information about the cfe-commits
mailing list