[PATCH] D95202: ADT: Use 'using' to inherit assign and append in SmallString

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith marked 2 inline comments as done.
dexonsmith added a comment.

Thanks for the review! Pushed with suggestions applied in ba5628f2c2a9de049b80b3e276f7e05f481c49e7 <https://reviews.llvm.org/rGba5628f2c2a9de049b80b3e276f7e05f481c49e7>.



================
Comment at: llvm/lib/Support/FileCollector.cpp:89-93
+  {
+    StringRef DroppedDotSlash = sys::path::remove_leading_dotslash(AbsoluteSrc);
+    if (DroppedDotSlash.begin() != AbsoluteSrc.begin())
+      AbsoluteSrc.erase(AbsoluteSrc.begin(), DroppedDotSlash.begin());
+  }
----------------
dblaikie wrote:
> Similar comment here as with ModuleDependencyCollector (actually there's a bunch of similar code here - perhaps it could be deduplicated in some way)
Yeah, I may follow up to fix that. It looks like a pure copy/paste...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95202/new/

https://reviews.llvm.org/D95202