[PATCH] D95168: [clang-format] Add InsertBraces option

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a subscriber: djasper.
MyDeveloperDay added a comment.

I think this is one of those reviews that ultimately I think would be useful if we could ensure it works 100% correctly, but I think it goes against the original ethos of clang-format and I think if @djasper or @klimek the original authors were here they'd probably push back.

This reminds me of my own work for a East/West fixer, it proved to be a bit too controversial for some, despite being off by default. but I also agree clang-format has been inserting and moving code around for some time, so its no longer just a whitespace manipulation tool.

I do like this, and I agree clang-tidy is often too heavy weight ( For my source tree which is millions of line of code running clang-tidy over the whole thing is just not possible). I personally run "clang-format -n" over my entire tree every night to sanity check it, this feature would allow me to enforce the use of {} without which I've found over the years is often a source of bugs.

lets see if others have an opinion


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95168/new/

https://reviews.llvm.org/D95168