[PATCH] D92808: [ObjC][ARC] Annotate calls with attributes instead of emitting retainRV or claimRV calls in the IR

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 22 12:31:38 PST 2021


rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

LGTM.  I know you mentioned doing this for more targets in follow-up commits.  It would be good to also do this for `-O0`, so that we have a single correct pattern coming out of the frontend in all modes; but that's also okay to do in follow-ups.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92808/new/

https://reviews.llvm.org/D92808



More information about the cfe-commits mailing list