[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

David Goldman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 22 10:21:10 PST 2021


dgoldman accepted this revision.
dgoldman added a comment.
This revision is now accepted and ready to land.

In D94919#2515987 <https://reviews.llvm.org/D94919#2515987>, @adamcz wrote:

> The crash happens while indexing the file, not during code completion. The code completion tests generally specify a cursor position, but in this case it is not relevant and could confuse the reader. This seemed like a logical place for indexing bug, in the spirit of using minimal repro case (i.e. you don't need to trigger code completion at all)

I see, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94919/new/

https://reviews.llvm.org/D94919



More information about the cfe-commits mailing list