[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration
David Goldman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 22 09:24:58 PST 2021
dgoldman requested changes to this revision.
dgoldman added a comment.
This revision now requires changes to proceed.
Looks good but I think for posterity we should add a similar test to clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp for the exact intended code complete behavior (or instead of SymbolCollectorTests.cpp - is there a particular reason you added a test there)?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94919/new/
https://reviews.llvm.org/D94919
More information about the cfe-commits
mailing list