[PATCH] D95225: [clang][cli] NFC: Pass CC1Option explicitly to BoolOption

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 22 05:18:51 PST 2021


jansvoboda11 created this revision.
jansvoboda11 added reviewers: Bigcheese, dexonsmith.
Herald added subscribers: dang, jfb.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

When `Bool{F,G}Option` were introduced, they were designed after the existing `Opt{In,Out}FFlag` in that they implied `CC1Option` for the `ChangedBy` flag.

This means less typing, but can be misleading in situations when the `ResetBy` has explicit `CC1Option` and `ChangedBy` doesn't.

This patch stops implicitly putting `CC1Option` to `ChangedBy` flag.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D95225

Files:
  clang/include/clang/Driver/Options.td

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95225.318492.patch
Type: text/x-patch
Size: 43620 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210122/37b9947d/attachment-0001.bin>


More information about the cfe-commits mailing list