[PATCH] D93986: [clang-format] Add the possibility to align assignments spanning empty lines or comments

[Lukas Barth via Phabricator via cfe-commits]

tinloaf added inline comments.


================
Comment at: clang/docs/tools/dump_format_style.py:194
+        # is used.
+        pass
     elif state == State.InEnumMemberComment:
----------------
curdeius wrote:
> Just a nit, maybe we should have a warning at least?
Not sure. After this commit gets in, we'll always have an enum (`AlignConsecutiveStyle`) with five undocumented options. Thus, every run of this script would emit five warnings, and these warnings would become "intended behavior". I think this would probably confuse people?

Sure, one could implement some more elaborate way of detecting an intentionally undocumented enum, but I guess this would mean a larger modification of this state machine, and I'd rather not lump this together with this PR.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93986/new/

https://reviews.llvm.org/D93986