[PATCH] D95087: [clangd] Inject context provider rather than config into ClangdServer. NFC

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jan 22 02:19:11 PST 2021


kadircet accepted this revision.
kadircet added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:277
+             D.getColumnNo(), D.getMessage());
+        break;
+      }
----------------
nit: maybe finish here with a `return` and unify the duplicated `if (ClientDiags) ClientDags->push_back..` after the `switch`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95087/new/

https://reviews.llvm.org/D95087



More information about the cfe-commits mailing list