[PATCH] D94942: [clangd] Add tweak for implementing abstract class

[Nathan James via Phabricator via cfe-commits]

njames93 added inline comments.


================
Comment at: clang-tools-extra/clangd/refactor/tweaks/ImplementAbstract.cpp:38-40
+      // If we have any pure virtual methods declared in the root (The class
+      // this tweak was invoked on), assume the user probably doesn't want to
+      // implement all abstract methods as the class will still be astract.
----------------
Is this a good behaviour, or should we still offer the tweak, even knowing that applying it will still result in the class being marked as abstract?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94942/new/

https://reviews.llvm.org/D94942