[PATCH] D93668: [clang] Override the Fuchsia platform ABI using the triple environment

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 21 13:42:34 PST 2021


rnk added a comment.

I guess the spelling -fc++-abi= is intuitive, discoverable, and easy to use. I'd be OK going back to that, as long as the compiler knows which ABIs work on which targets and rejects the unsupported configurations.

Regarding the idea of separating the platform ABI from the C++ ABI, I can't say I really believe in the idea of language neutral platform ABIs. The platform ABI always incorporates aspects of the most widely used source languages, typically C. This is where LLVM gets into trouble when non-C frontends want to pass _Complex values or structs as arguments, for example. Whether you think of C++ features as being part of the platform or not probably depends on your view on whether C++ support is a critical part of the platform. I tend to think of C++ as pretty critical, but I'm a C++ programmer working on C++ ABI support, so that's my view.

Regarding reducing global ABI switches, yes, I would like to minimize them. We have many, and they have costs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93668/new/

https://reviews.llvm.org/D93668



More information about the cfe-commits mailing list