[PATCH] D95007: [CUDA][HIP] Add -fuse-cuid

Thu Jan 21 13:37:09 PST 2021

yaxunl marked 2 inline comments as done.
yaxunl added inline comments.

================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2307
+  // Only alphanumeric and underscore is allowed in -cuid option.
+  if (auto *A = Args.getLastArg(OPT_cuid_EQ)) {
+    const char *V = A->getValue();
----------------
tra wrote:
> JonChesterfield wrote:
> > Why this limitation? In particular I can imagine people using an id based on a filesystem location, which introduces /\:. and possibly other characters.
> I guess one of the reasons is that CUID is used to create unique externally visible symbol names, so the charset is sort of the lowest common denominator that could be directly used in the symbol name.
> 
> We could work around that by accepting an arbitrary string as a CUID and then using its hash to create unique stable suffix.
will remove the check and use hash for suffix.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95007/new/

https://reviews.llvm.org/D95007