[PATCH] D94979: [CGExpr] Use getCharWidth() more consistently in CCGExprConstant. NFC

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added a comment.

I don't particularly want/like to straight-up derail this,
but my opinion still hasn't changed, and it is not unsubstantiated,
see https://lists.llvm.org/pipermail/llvm-dev/2019-May/132080.html, 
https://lists.llvm.org/pipermail/llvm-dev/2019-October/136115.html, etc,

I think the fact that last *two* recent-ish RFC's on this didn't succeed
suggests that a third one might be in order, perhaps with better arguments
this time, or maybe the previous opponents will just not block this..

TBN, i don't dislike the feature per-se, at least without seeing the full impact of the cleanup.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94979/new/

https://reviews.llvm.org/D94979