[PATCH] D92277: [OpenCL] Refactor of targets OpenCL option settings

[Anastasia Stulova via Phabricator via cfe-commits]

Anastasia accepted this revision.
Anastasia added a comment.

LGTM! Thanks! Great work! The comment can be addressed before committing.



================
Comment at: clang/include/clang/Basic/OpenCLOptions.h:165
+static inline llvm::SmallVector<std::string, 16>
+getCoreFeatures(const LangOptions &LO) {
+  llvm::SmallVector<std::string, 16> CoreFeatures;
----------------
I think we no longer need this? If so I suggest removing the function and if needed it can be added later?


================
Comment at: clang/test/Misc/nvptx.languageOptsOpenCL.cl:9
 // RUN: %clang_cc1 -x cl -cl-std=CL1.2 %s -verify -triple nvptx-unknown-unknown -Wpedantic-core-features -DTEST_CORE_FEATURES
-// RUN: %clang_cc1 -x cl -cl-std=CL2.0 %s -verify -triple nvptx-unknown-unknown -Wpedantic-core-features -DTEST_CORE_FEATURES
 // RUN: %clang_cc1 -x cl -cl-std=CL %s -verify -triple nvptx64-unknown-unknown
----------------
We should try to remember restoring some of these RUN lines once we have enough OpenCL 3.0 functionality.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92277/new/

https://reviews.llvm.org/D92277