[PATCH] D95016: [Clang][RISCV] Add custom TableGen backend for riscv-vector intrinsics.

Paul C. Anagnostopoulos via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 21 06:49:57 PST 2021


Paul-C-Anagnostopoulos added inline comments.


================
Comment at: clang/include/clang/Basic/riscv_vector.td:191
+        defvar suffix = s_p[1];
+        defvar prototype = s_p[2];
+
----------------
Well now, thanks for highlighting an inconsistency I did not know about. The documentation says that x[0] produces a list of the 0th element of x, which is why I suggested using !head. But that is true only in certain contexts, such as when x is a defvar. Otherwise it produces the single element. Ouch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95016/new/

https://reviews.llvm.org/D95016



More information about the cfe-commits mailing list