[PATCH] D94979: [CGExpr] Use getCharWidth() more consistently in ConstantAggregateBuilderUtils. NFC

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 20 10:21:40 PST 2021


rjmccall added a comment.

I don't mind generally abstracting Clang to handle this better.



================
Comment at: clang/lib/CodeGen/CodeGenModule.h:1229
+  // Return the LLVM type sized as one character unit.
+  llvm::Type *getCharSizedType();
+
----------------
Please just add a CharTy to CodeGenTypeCache.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94979/new/

https://reviews.llvm.org/D94979



More information about the cfe-commits mailing list